run all openshift4 tests even when one fails #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmiklank
force-pushed
the
run_all_openshift_tests_even_if_one_fails
branch
from
29c6c85 to
7bb1a33
Compare
Contributor
Author
|
[test-all] |
Member
|
@zmiklank Rebase please. |
Member
|
OpenShift 4 failures are fixed by #449 |
zmiklank
force-pushed
the
run_all_openshift_tests_even_if_one_fails
branch
from
7bb1a33 to
0d6f762
Compare
Contributor
Author
|
rebased. |
Member
|
Please rebase it. |
Member
|
As soon as PR is rebased then OpenShift 4 tests should be passing. |
The nounset shell option needs to be set after the OC login attempt, because (from man shopt): -u If expansion is attempted on an unset variable or parameter, the shell prints an error message, and, if not interactive exits with a non-zero status. That is in this matter inconvenient, as we do not really know from log what has happened if the oc login fails and moreover the test suite ends with success, as only the first failed test sets TESTSUITE_RESULT to 1. If we check login with the ct_os_check_login function, it handles the situation conveniently.
zmiklank
force-pushed
the
run_all_openshift_tests_even_if_one_fails
branch
from
0d6f762 to
4ab07f2
Compare
Contributor
Author
|
Rebased. |
Member
|
[test-all] |
phracek
approved these changes
Jun 30, 2022
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
Everything LGTM. Tests are passing and all GREEN again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[test-all]