chore: remove most editor mode config comments#1637
Merged
Conversation
yedayak
approved these changes
May 30, 2026
Collaborator
yedayak
left a comment
yedayak
left a comment
There was a problem hiding this comment.
I don't really have the context of what uses these comments, but looks good to me
akinomyoga
approved these changes
May 31, 2026
Collaborator
akinomyoga
left a comment
akinomyoga
left a comment
There was a problem hiding this comment.
I've thought GNU Emacs didn't recognize .bash, but I realized that the current version of Bash recognizes it. Perhaps it has recently added support, or I misunderstood.
In particular, remove them from files with names containing a typical extension for a language. These should be unnecessary at best, but an unknown mode or alias can also prevent a file from being opened with the correct mode. This is what happens currently with Zed 1.4.4, ref zed-industries/zed#58124
scop
force-pushed
the
chore/remove-most-mode-comments
branch
from
871bc5e to
ee9eab5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, remove them from files with names containing a typical extension for a language. These should be unnecessary at best, but an unknown mode or alias can also prevent a file from being opened with the correct mode.
This is what happens currently with Zed 1.4.4, ref zed-industries/zed#58124
Giant but trivial/comment-only PR.