test: create shadow completions dir for deprecated in-tree completions #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to test our deprecated completions instead of possibly non-deprecated out of tree ones installed in system dirs. Create a dir for them, symlink all of them without the underscore deprecation marker there, and inject the dir to the test suite's load path. Closes #836
3 tasks
akinomyoga
approved these changes
Nov 20, 2022
Collaborator
akinomyoga
left a comment
akinomyoga
left a comment
There was a problem hiding this comment.
Sorry, I now noticed this PR. I'm not sure what is the pre-commit error but approve this PR except for that.
No need to require running `configure` for this. Useful in general, but in particular with the pre-commit check, CI and otherwise.
Owner
Author
|
No problem, thanks for taking a peek. pre-commit failure addressed in 886d5e9, new fedoradev failure seems unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to test our deprecated completions instead of possibly non-deprecated out of tree ones installed in system dirs.
Create a dir for them, symlink all of them without the underscore deprecation marker there, and inject the dir to the test suite's load path.
Closes #836