Skip to content

fix: update npm and fix token escaping in release workflow#12

Merged
nastassiafulconis merged 5 commits intomainfrom
fix-npm-publish
Nov 6, 2025
Merged

fix: update npm and fix token escaping in release workflow#12
nastassiafulconis merged 5 commits intomainfrom
fix-npm-publish

Conversation

@nastassiafulconis
Copy link
Copy Markdown
Collaborator

Problem

The release workflow had two issues:

  1. Older npm version that may not support newer authentication features
  2. Token variable was escaped in .npmrc, writing literal ${NPM_TOKEN} instead of the actual token value

Changes

  • ✅ Added npm update step to ensure npm 11.5.1+ is installed
  • ✅ Fixed token escaping by removing backslash in echo command (line 40)

Root Cause

The escaped variable \${NPM_TOKEN} was writing the literal string instead of expanding to the actual token value, which meant npm never got authenticated properly.

Testing

Once merged, the release workflow should properly:

  1. Use latest npm with all authentication features
  2. Write the actual token to .npmrc
  3. Successfully publish to npm registry

- Remove registry-url from setup-node (causes conflicts)
- Add explicit .npmrc configuration step with NPM_TOKEN
- Matches pattern from working type-graphql release workflow
- Add npm update step to ensure npm 11.5.1+ is installed
- Fix token variable escaping in .npmrc (remove backslash)
- This should properly write the actual token value instead of literal ${NPM_TOKEN}
@nastassiafulconis nastassiafulconis requested a review from a team November 6, 2025 17:44
@nastassiafulconis nastassiafulconis merged commit ef1a5e0 into main Nov 6, 2025
6 checks passed
@nastassiafulconis nastassiafulconis deleted the fix-npm-publish branch November 6, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants