fix: update npm and fix token escaping in release workflow#12
Merged
nastassiafulconis merged 5 commits intomainfrom Nov 6, 2025
Merged
fix: update npm and fix token escaping in release workflow#12nastassiafulconis merged 5 commits intomainfrom
nastassiafulconis merged 5 commits intomainfrom
Conversation
- Remove registry-url from setup-node (causes conflicts) - Add explicit .npmrc configuration step with NPM_TOKEN - Matches pattern from working type-graphql release workflow
…nto fix-npm-publish
- Add npm update step to ensure npm 11.5.1+ is installed
- Fix token variable escaping in .npmrc (remove backslash)
- This should properly write the actual token value instead of literal ${NPM_TOKEN}
benminer
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow had two issues:
${NPM_TOKEN}instead of the actual token valueChanges
Root Cause
The escaped variable
\${NPM_TOKEN}was writing the literal string instead of expanding to the actual token value, which meant npm never got authenticated properly.Testing
Once merged, the release workflow should properly: