Fix styling#14
Merged
EmmaLouise2018 merged 1 commit intomainfrom Sep 7, 2022
Merged
Conversation
EmmaLouise2018
force-pushed
the
fix_styling
branch
2 times, most recently
from
255f499 to
41b7008
Compare
EmmaLouise2018
force-pushed
the
fix_styling
branch
from
41b7008 to
717e43a
Compare
EmmaLouise2018
force-pushed
the
fix_styling
branch
from
717e43a to
a17478b
Compare
asweeney86
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to PEP8: Class names must follow CamelCase naming (Each new word is capitalized without underscore)
According to PEP8, function and variable names should be lowercase with words separated by underscores. In PYLEECAN, small exceptions are made to this rule: a method or a variable name can have capitalized letter if and only if it follows physical quantities (radius=R, number=N or Z, length=L etc). For instance, Zs is used for the number of slots or Rbo for the lamination bore radius.