Conversation
benminer
added a commit
that referenced
this pull request
Sep 25, 2025
feat: major schema generation performance optimization - eliminate array-based type lookups
benminer
added a commit
that referenced
this pull request
Sep 25, 2025
* fix: remove use of "any" types in cache type definitions * fix: use Set() for middleware cache * fix: reset state on tests, move class init to BeforeEach instead of BeforeAll * commit build * rebuild * remove time logs * update build o/p * update build * remove benchmark build output * update build * update package-lock * Merge pull request #3 from scope3data/feature/performance-improvements feat: major schema generation performance optimization - eliminate array-based type lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Major Schema Generation Performance Optimization
This PR implements a comprehensive optimization of TypeGraphQL's schema generation by eliminating inefficient array-based type lookups and replacing them with O(1) map-based operations.
📊 Performance Impact
✅ Production Tested: Schema generation time reduced by multiple seconds in production environments
Key Improvements:
🛠 Technical Changes
Phase 1: Interface & Input Type Optimization
interfaceTypesInfo[]andinputTypesInfo[]Map.get()instead ofArray.find()filterOrphanedInterfaceTypes()andfilterOrphanedInputTypes()Phase 2: Object Type Optimization
objectTypesInfo[]filterOrphanedObjectTypes()Code Quality Improvements
filterTypesInfoByOrphanedTypesAndExtractType()method🏗 Architecture Changes
Before
After
✅ Comprehensive Testing
All existing test suites pass with zero regressions:
💡 Impact Analysis
Memory Efficiency
Lookup Performance
Scalability
🎯 Benefits for Production
🔒 Safety & Compatibility
Files changed: 4 files, +282 additions, -220 deletions
Focus:
src/schema/schema-generator.ts- core optimization logicThis optimization maintains TypeGraphQL's robust feature set while delivering significant performance improvements for schema generation across all use cases.