Fix user icon rendering and add method to get a smaller icon. #23
Conversation
| pub trait MessageAuthor: PartialEq + Eq { | ||
| fn get_display_name(&self) -> impl Element; | ||
| fn get_icon(&self) -> String; | ||
| fn get_small_icon(&self) -> String; |
There was a problem hiding this comment.
Im just wondering if another routine is really the correct way to go about this? Main questions I would ask are:
- Do we ever need to get a large icon for a message author?
If so, - Do we ever need to get anything other than a "normal" and "small" icon?
if 1 is no, Then I wouldn't add a new method and would just have the normal get_icon method return a 32px image.
If 1 is yes, then I think the better route would be an argument to get_icon.
If 2 is no, then that argument could be as simple as an enum IconSize
if 2 is yes, then that argument maybe should be something like a IconFormat config
| fn get_small_icon(&self) -> String { | ||
| self.icon.clone() + "?size=32" | ||
| } | ||
|
|
There was a problem hiding this comment.
one of my plans is to have get_icon return an Element. This way, discord for example, can display user icon decorations without us having to make an entire Chat interface for "decoration"
|
A better implementation is in the works, but this is good as a temporary fix |
4 participants
Removed the unnecessary white background. Added a method to fetch a smaller icon because there is no need to pull a large icon and downscaling it makes it look bad.