Skip to content

Channel History #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bvvst merged 16 commits into from
Nov 19, 2024
Merged

Channel History #33

bvvst merged 16 commits into from
Nov 19, 2024

Conversation

@roobscoob
Copy link
Contributor

@roobscoob roobscoob commented Nov 19, 2024

This PR implements:

  • Message history
  • Async Lists
  • An async list cache
  • An implementation of async list for discord channels
  • Async list renderer (specialized for channels, ideally this would be genericized, but I couldn't find a good abstraction for message merging)

Issues with this pr:

  • Async list rendering's scroll behaviour is still very weird when messages are added or removed. It's much better than main, but still very imperfect.
  • It's probably slow. No perf testing has been done

Atlas

@circularsprojects
Copy link
Contributor

circularsprojects commented Nov 19, 2024

can we try and fix the cargo clippy errors before merge

@roobscoob
Copy link
Contributor Author

roobscoob commented Nov 19, 2024

Will do

@roobscoob
Copy link
Contributor Author

roobscoob commented Nov 19, 2024

cargo clippy issues fixed. IMO this is ready to merge.

bvvst
bvvst approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@bvvst bvvst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:catnoyes:

@bvvst bvvst merged commit 7e392ba into scopeclient:main Nov 19, 2024
1 check passed
@roobscoob roobscoob deleted the channel-history branch November 19, 2024 22:31
circularsprojects pushed a commit to circularsprojects/scope that referenced this pull request Nov 20, 2024
@roobscoob @circularsprojects
Channel History (scopeclient#33)
5eec80a 
* started work on new datastructures + cache

* incomplete

* finish async list & async list cache

* Finished discord layer

* fix rendering bugs

* small changes

* scrolling *kinda* works

* first functional commit

* de-genericize async_list

* message grouping works again

* Fixed random scrolling up block

* scrolling updates

* update the way that list state is invalidated

* finalize

* cleanup & prepare for PR

* fix: make cargo clippy happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bvvst bvvst bvvst approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roobscoob @circularsprojects @bvvst