build: follow up vars edge cases#31
Merged
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
May 7, 2026
Comment on lines
+36
to
+41
| let commit_short = if commit.len() >= 8 { | ||
| let (commit_short, _) = commit.split_at(8); | ||
| commit_short | ||
| } else { | ||
| commit | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
When build with cargo install scopeql, there is no Git repo and thus commit = "". split_at(8) would panic.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes the initialization of build environment variables, corrects a typo in a Cargo build instruction, and adds a safety check for Git commit hash truncation to prevent panics. Review feedback recommends explicitly defining Cargo watch paths to ensure build metadata remains accurate and suggests using a more idiomatic string slicing method for the commit hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #30