Review round 2 jk #101
Merged
Review round 2 jk #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add reference to nodes * add custom reference ItemReference * document ItemReference * add minor tests for ItemReference * add table for scoring rationale to documentation * add ItemReferences For each item referring also to references of other nodes, add the corresponding ItemReferences * change ItemReference Since each reference's content was calculated, performance was quite bad. Therefore, the change of the content is now indirectly detected, only. * fix orphan-nodes * PJD-04 already covered by NPFs -> removed PJD-04 * linked TA-UPDATES and AOU-27 * remove unused code * re-formulate documentation for clarification * adapt formulation to be precise * remove unused pydot * change import of LocalFileReference to suppress warnings * add clarification of scope * improve function-reference * correct section counting * fix typo SCORE -> S-CORE
Signed-off-by: Erik Hu <135733975+Erikhu1@users.noreply.github.com>
* fix function-reference * add support for multiline function declarations * add test for multiline function declaration * fix error-messages
github-actions
bot
added
documentation
Erikhu1
force-pushed
the
review_round_2
branch
from
8a42aa9 to
e8ea224
Compare
Signed-off-by: Jonas-Kirchhoff <jonas.kirchhoff@d-fine.com>
Erikhu1
approved these changes
Oct 8, 2025
Erikhu1
added a commit
that referenced
this pull request
Oct 23, 2025
* library version * AOU-03 shall * AOU-25 'used' standard library * fix AOU-26 * add context diagram * fix introduction * Review round 2 jk (#93) * Add reference to nodes * add custom reference ItemReference * document ItemReference * add minor tests for ItemReference * add table for scoring rationale to documentation * add ItemReferences For each item referring also to references of other nodes, add the corresponding ItemReferences * change ItemReference Since each reference's content was calculated, performance was quite bad. Therefore, the change of the content is now indirectly detected, only. * fix orphan-nodes * PJD-04 already covered by NPFs -> removed PJD-04 * linked TA-UPDATES and AOU-27 * remove unused code * re-formulate documentation for clarification * adapt formulation to be precise * remove unused pydot * change import of LocalFileReference to suppress warnings * add clarification of scope * improve function-reference * correct section counting * fix typo SCORE -> S-CORE * Review round 2 jk (#96) * fix function-reference * add support for multiline function declarations * add test for multiline function declaration * fix error-messages * Review round 2 jk (#101) * remove reference ListOfTestCases * add folder artifacts to gitignore * add generator for the list of test environments * generate list of test environments * add validator for list of test environments * document generator * implement evidence * remove obsolete tests * add tests for ListOfTestsGenerator * repair pytest execution --------- Signed-off-by: Erik Hu <135733975+Erikhu1@users.noreply.github.com> Signed-off-by: Jonas-Kirchhoff <jonas.kirchhoff@d-fine.com> Co-authored-by: Erik Hu <erik.hu@d-fine.com> Co-authored-by: Erik Hu <135733975+Erikhu1@users.noreply.github.com> * add root to syspath * remove @classmethods from init * clean up * clean up * explain generate_list_of_tests.py --------- Signed-off-by: Erik Hu <135733975+Erikhu1@users.noreply.github.com> Signed-off-by: Jonas-Kirchhoff <jonas.kirchhoff@d-fine.com> Co-authored-by: Jonas-Kirchhoff <jonas.kirchhoff@d-fine.com>
Erikhu1
added a commit
that referenced
this pull request
Nov 14, 2025
* library version * AOU-03 shall * AOU-25 'used' standard library * fix AOU-26 * add context diagram * fix introduction * Review round 2 jk (#93) * Add reference to nodes * add custom reference ItemReference * document ItemReference * add minor tests for ItemReference * add table for scoring rationale to documentation * add ItemReferences For each item referring also to references of other nodes, add the corresponding ItemReferences * change ItemReference Since each reference's content was calculated, performance was quite bad. Therefore, the change of the content is now indirectly detected, only. * fix orphan-nodes * PJD-04 already covered by NPFs -> removed PJD-04 * linked TA-UPDATES and AOU-27 * remove unused code * re-formulate documentation for clarification * adapt formulation to be precise * remove unused pydot * change import of LocalFileReference to suppress warnings * add clarification of scope * improve function-reference * correct section counting * fix typo SCORE -> S-CORE * Review round 2 jk (#96) * fix function-reference * add support for multiline function declarations * add test for multiline function declaration * fix error-messages * Review round 2 jk (#101) * remove reference ListOfTestCases * add folder artifacts to gitignore * add generator for the list of test environments * generate list of test environments * add validator for list of test environments * document generator * implement evidence * remove obsolete tests * add tests for ListOfTestsGenerator * repair pytest execution --------- Signed-off-by: Erik Hu <135733975+Erikhu1@users.noreply.github.com> Signed-off-by: Jonas-Kirchhoff <jonas.kirchhoff@d-fine.com> Co-authored-by: Erik Hu <erik.hu@d-fine.com> Co-authored-by: Erik Hu <135733975+Erikhu1@users.noreply.github.com> * add root to syspath * remove @classmethods from init * clean up * clean up * explain generate_list_of_tests.py --------- Signed-off-by: Erik Hu <135733975+Erikhu1@users.noreply.github.com> Signed-off-by: Jonas-Kirchhoff <jonas.kirchhoff@d-fine.com> Co-authored-by: Jonas-Kirchhoff <jonas.kirchhoff@d-fine.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework the list of test environments