Revision 1 jk #77
Merged
Revision 1 jk #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add trudag as the first job to the publish_documentation workflow (uploads the trudag report as an artifact) - Adjusted the original eclipse publication workflow to download the trudag report before building the documentation
- The cpp test reference in the trudag report is rendered with some mkdocs specific formatting that is now removed by the cleaning script
The statements in well-formed-json were overlapping. To remove the over- lap, we reworked the statements and condensed them into eight distinct.
- created no-json-faults as specificications for WFJ-01, WFJ-04, WFJ-05. - added this to trustable graph
- Add No-JSON-Faults (NJF-08) about accepting numbers - Added this below WFJ-03
Erikhu1
reviewed
Sep 10, 2025
| # generate TSF report | ||
| TSF_SCRIPT_FOLDER=$(dirname "$(realpath $0)") | ||
| $TSF_SCRIPT_FOLDER/generate_report.sh | ||
| $TSF_SCRIPT_FOLDER/generate_report.sh $1 |
Collaborator
There was a problem hiding this comment.
How does this work? what's purpose of the '$1'?
Author
There was a problem hiding this comment.
The $1 is an input in the console, which is given to generate_report.sh. There, this input is given to plot_partial_graphs.py, where it takes the role of the base url, which is used to generate the links in the trustable graphs. I shall comment.
Erikhu1
reviewed
Sep 10, 2025
TSF/scripts/plot_partial_graphs.py
Outdated
| import trudag.plot as plt | ||
| from pathlib import Path | ||
|
|
||
| def get_my_url(vertex: str, base_url: str, fuLl_graph: TrustableGraph) -> str: |
Collaborator
There was a problem hiding this comment.
typo capitalized L in fuLl_graph
Author
There was a problem hiding this comment.
Very keen-eyed! Funnily enough, this typo did not even matter, since it was embarrassingly repeated three times!
TSF/scripts/plot_partial_graphs.py
Outdated
| def get_my_url(vertex: str, base_url: str, fuLl_graph: TrustableGraph) -> str: | ||
| # if vertex in fuLl_graph._graph.root_nodes(): | ||
| # return base_url+"_images/graph.svg" | ||
| if vertex in fuLl_graph._graph.leaf_nodes(): |
Collaborator
There was a problem hiding this comment.
typo capitalized L in fuLl_graph
| # return base_url+"_images/graph.svg" | ||
| if vertex in fuLl_graph._graph.leaf_nodes(): | ||
| return base_url+"/generated/"+fuLl_graph.get_item(vertex).document+".html#"+vertex.lower() | ||
| else: |
Collaborator
There was a problem hiding this comment.
typo capitalized L in fuLl_graph
Erikhu1
pushed a commit
that referenced
this pull request
Nov 14, 2025
* add automatic partial graph generator * add linking to plots in documentation * add linkage to report generator * revert changes for development purposes * Change JLEX into links * reorder documentation * rework plotting * adapt documentation generator to argument * change link of top-top-layer node * pin versions * Fix broken grammar * add missing commata * clarify role of input for shell scripts * change variable name --------- Co-authored-by: Nils Eberhardt <nils.eberhardt@d-fine.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new interactive presentation of the trustable graph automatically generated during generation of the documentation.