Skip to content

Resources command update in score-compose and score-k8s cli files#158

Merged
mathieu-benoit merged 4 commits intoscore-spec:mainfrom
siddhiguptas:resources-command-update
Feb 21, 2025
Merged

Resources command update in score-compose and score-k8s cli files#158
mathieu-benoit merged 4 commits intoscore-spec:mainfrom
siddhiguptas:resources-command-update

Conversation

@siddhiguptas
Copy link
Contributor

Added resources commands in the score-k8s cli.md file and in the score-compose cli.md file

fixes#125

@siddhiguptas
Copy link
Contributor Author

@mathieu-benoit Hii

@mathieu-benoit
Copy link
Contributor

Thanks for your contribution, @Siddhi905 , much appreciated!

Could you please resolve the 2 current issues you have in the CI of this PR?

DCO: you'll need to sign your commits, you can run this for example to sign your 2 previous commits:

git rebase HEAD~2 --signoff
git push --force-with-lease origin resources-command-update

Compile Hugo failure, you have this error to fix too:

from /home/runner/work/docs/docs/content/en/docs/score implementation/score-k8s/cli.md:
229 229| score-k8s·resources·--verbose
230 230| ```
231 231| 
    232|-
232 233| ##·`help`
233 234| 
234 235| The·`help`·command·provides·information·on·all·commands.
--
Found 1 not formatted file.
error Command failed with exit code [20](https://github.com/score-spec/docs/actions/runs/13391804290/job/37498017925?pr=158#step:7:21).

Thanks!

Signed-off-by: Siddhi905 <siddhigupta811@gmail.com>
Signed-off-by: Siddhi905 <siddhigupta811@gmail.com>
@siddhiguptas siddhiguptas force-pushed the resources-command-update branch from 9003fed to a777064 Compare February 20, 2025 14:28
Signed-off-by: Siddhi905 <siddhigupta811@gmail.com>
Signed-off-by: Siddhi905 <siddhigupta811@gmail.com>
@siddhiguptas siddhiguptas force-pushed the resources-command-update branch from e40a927 to 1309ec2 Compare February 20, 2025 16:35
@siddhiguptas
Copy link
Contributor Author

Done!

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mathieu-benoit
Copy link
Contributor

@astromechza, a second pair of eyes on this one please?

@mathieu-benoit mathieu-benoit merged commit 122ae08 into score-spec:main Feb 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Document the score-* resources commands in CLI docs

3 participants