Merged
Conversation
Fixes #120. Steps: * Added a call to `AgentContext.build()` to restore functionality. This is the only thing that broke. I used `git bisect` to discover that it was broken in 6ab579e, which is when `AgentContext` was refactored. * Refactored to remove the unnecessary extra functions for the subparsers * Removed unnecessary subparser name validity check, as this is done by argparse already * Restored test coverage checking for the file * Added some basic tests to get to 100% coverage
adamchainz
force-pushed
the
fix_core_agent_manager
branch
from
6c83f86 to
2205bcb
Compare
dlanderson
approved these changes
Jul 3, 2019
Contributor
dlanderson
left a comment
dlanderson
left a comment
There was a problem hiding this comment.
Great, thanks for fixing it! This script comes in handy for those people who would want to manage the core agent outside of the instrumented application for various reasons.
dlanderson
approved these changes
Jul 3, 2019
Contributor
Author
|
Do you think it's worth documenting now then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120. Steps:
AgentContext.build()to restore functionality. This is theonly thing that broke. I used
git bisectto discover that it was broken in6ab579e, which is when
AgentContextwasrefactored.
argparse already