Close file descriptors when launching core agent#219
Merged
adamchainz merged 1 commit intomasterfrom Aug 3, 2019
Merged
Conversation
adamchainz
force-pushed
the
issue_216_close_fds
branch
from
fe51dd3 to
6bfc871
Compare
Fixes #216. This is the default [Python 3.4+](https://docs.python.org/3/library/os.html#fd-inheritance). Tested with https://github.com/adamchainz/scout-test-apps/commit/61f0197e5731c3a6709a1520d08a2102d53a0217 before and after, checking `lsof -nP -i :8000` to see if the core agent process was holding onto the port.
adamchainz
force-pushed
the
issue_216_close_fds
branch
from
6bfc871 to
a8168f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216.
This is the default on Python 3.4+.
Tested with https://github.com/adamchainz/scout-test-apps/commit/61f0197e5731c3a6709a1520d08a2102d53a0217 before and after, checking
lsof -nP -i :8000to see if the core agent process was holding onto the port.