Guard against undetermined CPU count#245
Merged
adamchainz merged 1 commit intomasterfrom Aug 30, 2019
Merged
Conversation
Spotted whilst adding test coverage in #242. The [`psutil.cpu_count` docs](https://psutil.readthedocs.io/en/latest/#psutil.cpu_count) say it can return `None` in the case that the CPU count cannot be determined. This would lead to a `TypeError` in the multiplication, so fix that by assuming 'undetermined' means one CPU - incorrect statistics, but better than nothing.
adamchainz
force-pushed
the
fix_cpu_count
branch
from
255e6ee to
da5ee80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted whilst adding test coverage in #242.
The
psutil.cpu_countdocs say it can returnNonein the case that the CPU count cannot be determined. This would lead to aTypeErrorin the multiplication, so fix that by assuming 'undetermined' means one CPU - incorrect statistics, but better than nothing.