Remove exec calls from Elasticsearch instrument#348
Merged
adamchainz merged 2 commits intomasterfrom Nov 4, 2019
Merged
Conversation
Part of #342. Also tidy up the import pattern, smiilar to Redis changes in #341, and fix index name tracking when not passed as a keyword argument. The speed difference is smaller than I thought. Before: ``` In [2]: %timeit Instrument().install(); Instrument().uninstall() 95.5 µs ± 2.07 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each) ``` After: ``` In [2]: %timeit Instrument().install(); Instrument().uninstall() 89.5 µs ± 674 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each) ``` However the other benefits still stand - code being linted, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #342.
Also tidy up the import pattern, smiilar to Redis changes in #341, and fix index name tracking when not passed as a keyword argument.
The speed difference is smaller than I thought.
Before:
After:
However the other benefits still stand - code being linted, etc.