Add support for negative timestamp#1060
Merged
Gallaecio merged 5 commits intoscrapinghub:masterfrom Jun 17, 2022
Merged
Conversation
ghost
marked this pull request as ready for review
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 234 234
Lines 2694 2701 +7
=======================================
+ Hits 2648 2655 +7
Misses 46 46
Continue to review full report at Codecov.
|
gutsytechster
force-pushed
the
negative-timestamp
branch
from
22ff8ed to
b8537d2
Compare
gutsytechster
force-pushed
the
negative-timestamp
branch
from
b8537d2 to
4bc90c6
Compare
ghost
changed the title
Gallaecio
approved these changes
Jun 14, 2022
* (date.py): only matches positive timestamp when given, not the default. * (test_date.py): replace ``negative_allowed`` with ``negative`` to avoid any assumption that both postive and negative are parsed. * (settings.rst): improve doc statement for ``negative-timestamp`` parser.
Gallaecio
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #546