Fix explicit +/- signs in relative date offsets#1303
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
+ Coverage 96.60% 96.62% +0.01%
==========================================
Files 235 235
Lines 2889 2905 +16
==========================================
+ Hits 2791 2807 +16
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes parsing of relative date expressions containing explicit +/- time offsets (e.g., "yesterday +1h"), addressing issue #1299.
Changes:
- Updated
FreshnessDateDataParserto recognize signed numeric quantities (e.g.,+1 hour,-30 minutes) and apply them correctly. - Added regression tests validating
"yesterday"/"tomorrow" +/- <offset>parsing behavior viadateparser.parse().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
dateparser/freshness_date_parser.py |
Extends unit parsing regex to accept +/- and adjusts relativedelta application to respect explicit signs. |
tests/test_date_parser.py |
Adds parameterized coverage for "yesterday"/"tomorrow" +/- offsets plus targeted regression assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gallaecio
approved these changes
Jan 29, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wRAR
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1299