Skip to content

Conversation

@ivanprado
Copy link
Contributor

No description provided.

@ivanprado ivanprado requested a review from kmike February 14, 2019 13:20
HISTORY.rst Outdated
v0.7.2 (TBA)
------------

* ignore any exception if errors='ignore'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! would you mind making it a bit more detailed, e.g. which function is this argument for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmike hope now is more clear.

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files          11       11           
  Lines         469      469           
  Branches      101      101           
=======================================
  Hits          411      411           
  Misses         52       52           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99b14d...f2a28d6. Read the comment docs.

HISTORY.rst Outdated

* Cover all possible exception cases dealt by ``extruct()`` ``errors`` attribute for values ``strict``, ``log`` and ``ignore``
* avoid including ``itemprop`` from child ``itemscope`` when using ``itemref``
* proper processing order for ``itemref``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind mentioning which extractors / semantic markup formats it affects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @kmike. Done!

@kmike kmike merged commit e245102 into scrapinghub:master Feb 14, 2019
@kmike
Copy link
Member

kmike commented Feb 14, 2019

Thanks @ivanprado!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants