Skip to content

Conversation

@Gallaecio
Copy link
Member

Removes the HTTP API, as it adds complexity to the code base without adding much value.

Part 1 of 2 of #63

Closes #111

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files          11       11           
  Lines         475      475           
  Branches      103      103           
=======================================
  Hits          417      417           
  Misses         52       52           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2662e6...d16d6e6. Read the comment docs.

@kmike kmike merged commit f806df0 into scrapinghub:master Jan 15, 2020
@kmike
Copy link
Member

kmike commented Jan 15, 2020

Let's remove it - thanks @Gallaecio! Also, thanks @cathalgarvey for the idea.
If there is an interest, code can be easily moved out of extruct, to a separate repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RecursionError('maximum recursion depth exceeded while calling a Python object',)

2 participants