Skip to content

Conversation

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Apr 20, 2020

As I understand, we release to pypi automatically on git tags - I plan to tag after merging this PR into master.

@lopuhin lopuhin requested a review from kmike April 20, 2020 12:40
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files          11       11           
  Lines         475      475           
  Branches      103      103           
=======================================
  Hits          417      417           
  Misses         52       52           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d9021...88303b5. Read the comment docs.

@kmike
Copy link
Member

kmike commented Apr 20, 2020

hey! I think we've done it like this in past:

  1. merge a PR with changelog (with a version already in)
  2. update all versions everywhere & add a git tag, by running bumpversion minor --dry-run --verbose (to check if everything is ok) and then bumpversion minor and then pushing everything to github, including tags

@kmike
Copy link
Member

kmike commented Apr 20, 2020

bumpversion command should add a proper git tag & update version numbers in all necessary places

@lopuhin
Copy link
Member Author

lopuhin commented Apr 20, 2020

Thanks @kmike I reverted the version change, will update the docs on how to make a release once I make it

@kmike kmike merged commit 373f765 into master Apr 20, 2020
@kmike
Copy link
Member

kmike commented Apr 20, 2020

thanks @lopuhin!

@kmike
Copy link
Member

kmike commented Apr 20, 2020

Feel free to push the version change to master

@lopuhin lopuhin deleted the release-0.9.0 branch April 20, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants