-
Notifications
You must be signed in to change notification settings - Fork 119
Document how to make releases #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 12 12
Lines 539 539
Branches 122 122
=======================================
Hits 481 481
Misses 52 52
Partials 6 6 Continue to review full report at Codecov.
|
the kind of tag created with bumpversion does not get pushed with --follow-tags
|
Sorry for the mess with multiple tried to make a release in master, original sequence didn't work and then I didn't notice that upload already succeeded on the next try. Documented the working sequence, hope it goes smoother next time. |
|
Thanks @lopuhin! Do you think we can move it to wiki? |
@kmike good point, I can move it along with bumpversion mention. Another option besides the wiki is to have it in git, e.g. in |
|
I think both are fine, not strong preference. I've seen @Gallaecio updating release procedure in wiki almost on each release sometimes, when it's complex (in such case it looks better suited for wiki), but here it looks pretty straightforward. |
|
Aha I didn't know we already use wiki for that purpose, nice, make sense to follow the same approach here. |
|
We're not using it for this repo, but we have release procedure in wiki for Scrapy, Splash and some other Open Source packages we maintain - see e.g. https://github.com/scrapy/scrapy/wiki/Scrapy-release-procedure or https://github.com/scrapinghub/splash/wiki/How-to-make-a-Splash-release. |
|
Thanks for context @kmike , makes sense to use a similar approach across our repos. Created a wiki page https://github.com/scrapinghub/extruct/wiki and removed stuff from the README. |
|
Thanks @lopuhin for taking care of that! |
|
thanks @kmike ! |
TODO: