Skip to content

Conversation

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Sep 1, 2020

TODO:

  • try to follow this for 0.10.0 release

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          12       12           
  Lines         539      539           
  Branches      122      122           
=======================================
  Hits          481      481           
  Misses         52       52           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c310c5...063e10b. Read the comment docs.

@lopuhin lopuhin changed the title [WIP] Document how to make releases Document how to make releases Sep 1, 2020
@lopuhin lopuhin changed the title Document how to make releases [WIP] Document how to make releases Sep 1, 2020
the kind of tag created with bumpversion does not get pushed with
--follow-tags
@lopuhin lopuhin changed the title [WIP] Document how to make releases Document how to make releases Sep 1, 2020
@lopuhin
Copy link
Member Author

lopuhin commented Sep 1, 2020

Sorry for the mess with multiple tried to make a release in master, original sequence didn't work and then I didn't notice that upload already succeeded on the next try. Documented the working sequence, hope it goes smoother next time.

@lopuhin lopuhin requested a review from kmike September 1, 2020 18:36
@kmike
Copy link
Member

kmike commented Sep 1, 2020

Thanks @lopuhin!
The sequence makes sense to me, especially as you checked that it works :)

Do you think we can move it to wiki?
This is information for maintainers, not for general extruct users.

@lopuhin
Copy link
Member Author

lopuhin commented Sep 1, 2020

Do you think we can move it to wiki? This is information for maintainers, not for general extruct users.

@kmike good point, I can move it along with bumpversion mention. Another option besides the wiki is to have it in git, e.g. in RELEASE.rst or MAINTENANCE.rst for easier discoverability, what do you think?

@kmike
Copy link
Member

kmike commented Sep 1, 2020

I think both are fine, not strong preference. I've seen @Gallaecio updating release procedure in wiki almost on each release sometimes, when it's complex (in such case it looks better suited for wiki), but here it looks pretty straightforward.

@lopuhin
Copy link
Member Author

lopuhin commented Sep 1, 2020

Aha I didn't know we already use wiki for that purpose, nice, make sense to follow the same approach here.

@kmike
Copy link
Member

kmike commented Sep 1, 2020

We're not using it for this repo, but we have release procedure in wiki for Scrapy, Splash and some other Open Source packages we maintain - see e.g. https://github.com/scrapy/scrapy/wiki/Scrapy-release-procedure or https://github.com/scrapinghub/splash/wiki/How-to-make-a-Splash-release.

@lopuhin
Copy link
Member Author

lopuhin commented Sep 2, 2020

Thanks for context @kmike , makes sense to use a similar approach across our repos. Created a wiki page https://github.com/scrapinghub/extruct/wiki and removed stuff from the README.

@kmike kmike merged commit df7ca6b into master Sep 2, 2020
@kmike
Copy link
Member

kmike commented Sep 2, 2020

Thanks @lopuhin for taking care of that!

@lopuhin
Copy link
Member Author

lopuhin commented Sep 2, 2020

thanks @kmike !

@lopuhin lopuhin deleted the making-release branch September 2, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants