Skip to content

Conversation

@Kebniss
Copy link
Contributor

@Kebniss Kebniss commented Oct 26, 2018

as reported here #95

@Kebniss Kebniss requested a review from kmike October 26, 2018 00:41
@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          11       11           
  Lines         434      434           
  Branches       89       89           
=======================================
  Hits          384      384           
  Misses         44       44           
  Partials        6        6
Impacted Files Coverage Δ
extruct/jsonld.py 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b459dbf...fd7d67c. Read the comment docs.

@Kebniss
Copy link
Contributor Author

Kebniss commented Oct 26, 2018

@kmike how does it work with gdpr now? Can I download this page and add it to tests? https://www.tasteofhome.com/collection/keto-diet-recipes/view-all/

Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, thanks for the fix @Kebniss!

@kmike kmike merged commit 18f41f1 into master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants