better Python 3.7 support #97
Conversation
kmike
commented
Nov 1, 2018
kmike
commented
- added Python 3.7 to tests
- fix Python 3.7 warnings
- improve DeprecationWarning, so that it points to a caller code
* added Python 3.7 to tests * fix Python 3.7 warnings * improve DeprecationWarning, so that it points to a caller code
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
======================================
Coverage 88.7% 88.7%
======================================
Files 11 11
Lines 434 434
Branches 89 89
======================================
Hits 385 385
Misses 44 44
Partials 5 5
Continue to review full report at Codecov.
|
| result.update(extruct.extract(resp.content, | ||
| url=url, | ||
| result.update(extruct.extract(resp.content, | ||
| base_url=url, # FIXME: use base url |
There was a problem hiding this comment.
One more reason to deprecate the tool - I was going to suggest using get_base_url from w3lib, but it seems this would require more extra code to handle encodings correctly (and we are already throwing encoding information away here by not using headers).
There was a problem hiding this comment.
Yeah, actually I started adding get_base_url, then realized encodings need to be handled, etc., removed that, and just added FIXME comment instead :)
