Revive NEWS file from GIT history #37
Conversation
Current coverage is 93.80% (diff: 100%)@@ master #37 diff @@
==========================================
Files 14 14
Lines 1178 1178
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1105 1105
Misses 73 73
Partials 0 0
|
NEWS
Outdated
|
|
||
| Version 1.9.0 | ||
| ------------- | ||
| (release on Nov 2nd, 2016) |
There was a problem hiding this comment.
why not to include date in the header, seems to be common practice
https://github.com/scrapy/scrapy/blob/master/docs/news.rst
https://github.com/kennethreitz/requests/blob/master/HISTORY.rst
I like requests approach <version> (<date>) the most - short and clean
There was a problem hiding this comment.
Sounds good, will do!
There was a problem hiding this comment.
Note that starting with a digit seems to cause trouble with generated link (for Sphinx at least)
e.g for "2.12.3 (2016-12-01)", the link is
http://docs.python-requests.org/en/master/community/updates/#id1
I "fixed" it in Scrapy by prepending "Scrapy " (scrapy/scrapy#2294)
There was a problem hiding this comment.
Thanks for the hint @redapple!
@chekunkov Maybe prepend with just v like v1.9.0 (2016-11-02)?
Hmm, maybe not necessary, I've done some tests and it works fine at least with Github:
https://github.com/scrapinghub/python-scrapinghub/blob/temp-test-links/NEWS.rst#180-2016-07-29
There was a problem hiding this comment.
that's strange @redapple we'll change the headers later if starting digit will stand in our way :)
NEWS
Outdated
| - all tests are improved and rewritten with py.test | ||
| - hubstorage tests use vcrpy cassettes, work faster and don't require any external services to run | ||
|
|
||
| python-hubstorage is going to be considered deprecated, |
There was a problem hiding this comment.
can we add a link to python-hubstorage?
vshlapakov
changed the title
vshlapakov
changed the title
Revive NEWS file based on GIT history.
Review, please.