Convert proxy logic to subclasses #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## readthedocs #61 +/- ##
===============================================
- Coverage 92.83% 92.81% -0.02%
===============================================
Files 27 28 +1
Lines 1855 1866 +11
===============================================
+ Hits 1722 1732 +10
- Misses 133 134 +1
Continue to review full report at Codecov.
|
chekunkov
reviewed
Mar 28, 2017
scrapinghub/client/proxy.py
Outdated
|
|
||
| class _ItemsResourceProxy(_Proxy): | ||
|
|
||
| def get(self, _key, **params): |
Contributor
There was a problem hiding this comment.
missing docstring
TIL items.get :)
In [7]: job.items.get(0)
Out[7]:
{u'_type': u'Page',
u'referer': None,
u'size': u'24836',
u'title': u'Web Crawling Platform & Data as a Service | Scrapinghub',
u'url': u'https://scrapinghub.com/'}
Make wrap_http_errors private and remove wrap_value_too_large because it's not needed any more.
vshlapakov
force-pushed
the
readthedocs-proxy
branch
from
dc5724c to
c1399be
Compare
chekunkov
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As current proxy logic is based on adding a lot of methods in runtime on instantiating entities - all the methods are unavailable in documentation which is a serious drawback. It was decided to replace the approach with a set of subclasses of
_Proxy, each is responsible for its own methods, and other missing methods should be added to target classes.Some side changes in the PR:
format_iter_filtersmethoditer_raw_*methods