Skip to content

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented Nov 26, 2022

Closes #137

Keys taken from the upstream implementation (except for redirect_ttl, there is no way to limit redirects in Playwright AFAICT).

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #142 (a6d2c5f) into main (ee55049) will decrease coverage by 3.03%.
The diff coverage is 44.44%.

❗ Current head a6d2c5f differs from pull request most recent head dc1ee27. Consider uploading reports for the commit dc1ee27 to get more accurate results

@@             Coverage Diff             @@
##              main     #142      +/-   ##
===========================================
- Coverage   100.00%   96.96%   -3.04%     
===========================================
  Files            2        2              
  Lines          311      329      +18     
===========================================
+ Hits           311      319       +8     
- Misses           0       10      +10     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 96.86% <44.44%> (-3.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta marked this pull request as ready for review November 27, 2022 01:40
@elacuesta elacuesta merged commit 6853d94 into main Nov 27, 2022
@elacuesta elacuesta deleted the redirects branch November 27, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting redirect_urls

3 participants