Skip to content

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented May 11, 2022

See https://playwright.dev/python/docs/release-notes#version-115

Tasks:

  • Use new headers API
  • Deprecate scrapy_playwright.headers.use_playwright_headers in favor of setting PLAYWRIGHT_PROCESS_REQUEST_HEADERS=None

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #93 (433cdb5) into master (a632118) will increase coverage by 0.35%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master       #93      +/-   ##
===========================================
+ Coverage   99.64%   100.00%   +0.35%     
===========================================
  Files           4         4              
  Lines         285       297      +12     
===========================================
+ Hits          284       297      +13     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)
scrapy_playwright/headers.py 100.00% <100.00%> (+6.66%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@elacuesta elacuesta merged commit b36a79f into master May 14, 2022
@elacuesta elacuesta deleted the use-new-upstream-headers-api branch May 14, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants