Skip to content

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented May 14, 2022

Closes #52

Pass user_data_dir as a keyword argument (PLAYWRIGHT_CONTEXTS setting, playwright_context_kwargs request meta key) to launch a context as persistent. See BrowserType.launch_persistent_context. Persistent and non-persistent contexts can be used at the same time.

Tasks:

  • Implementation
  • Docs
  • Tests
  • Example

@elacuesta elacuesta added the enhancement New feature or request label May 14, 2022
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #94 (e119c62) into master (9d612df) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          297       322   +25     
=========================================
+ Hits           297       322   +25     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@elacuesta elacuesta marked this pull request as ready for review May 15, 2022 03:21
@elacuesta elacuesta force-pushed the launch-persistent-context branch from f348ab4 to 2ff494f Compare May 16, 2022 00:25
@elacuesta elacuesta changed the title Launch persistent context Persistent contexts May 16, 2022
@elacuesta elacuesta merged commit c32d720 into master May 18, 2022
@elacuesta elacuesta deleted the launch-persistent-context branch May 18, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can I use launch_persistent_context in scrapy-playwright ?

2 participants