Skip to content

Specify project url and support Python - 3.8, 3.9 and 3.10#20

Merged
whalebot-helmsman merged 1 commit intoscrapy:masterfrom
anubhavp28:py3.8_and_py3.9_support
Feb 11, 2022
Merged

Specify project url and support Python - 3.8, 3.9 and 3.10#20
whalebot-helmsman merged 1 commit intoscrapy:masterfrom
anubhavp28:py3.8_and_py3.9_support

Conversation

@anubhavp28
Copy link
Copy Markdown
Collaborator

@anubhavp28 anubhavp28 commented Feb 11, 2022

Hi, we could specify the project URL in setup.py. Also, we could make tox run tests with Python 3.8 and 3.9 as well.

@anubhavp28 anubhavp28 force-pushed the py3.8_and_py3.9_support branch 3 times, most recently from 3b6811e to 147823f Compare February 11, 2022 03:02
@Gallaecio
Copy link
Copy Markdown
Member

What about Python 3.10?

@anubhavp28 anubhavp28 force-pushed the py3.8_and_py3.9_support branch from 147823f to 8712d49 Compare February 11, 2022 12:31
@anubhavp28 anubhavp28 changed the title Specify project url and support Py3.8 and Py3.9 Specify project url and support Python - 3.8, 3.9 and 3.10 Feb 11, 2022
@anubhavp28 anubhavp28 force-pushed the py3.8_and_py3.9_support branch from 8712d49 to 5eaa0b0 Compare February 11, 2022 12:40
@anubhavp28
Copy link
Copy Markdown
Collaborator Author

added Python 3.10 as well.

@Gallaecio
Copy link
Copy Markdown
Member

Thanks!

@anubhavp28
Copy link
Copy Markdown
Collaborator Author

anubhavp28 commented Feb 11, 2022

Should I merge this? I thinking of making 0.2 release of Protego. I received an email from someone about they being stuck at something because Protego doesn't support Python 3.8.

@Gallaecio
Copy link
Copy Markdown
Member

+1 from me

Copy link
Copy Markdown
Collaborator

@whalebot-helmsman whalebot-helmsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update @anubhavp28

@whalebot-helmsman whalebot-helmsman merged commit 1a64111 into scrapy:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants