[MRG+1] fix: preservation of url encoded hash signs. #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* issue scrapy#91 * description: don't decode `%23` to `#` when it appears in a url * tests-new: test_url.CanonicalizeUrlTest.test_preserve_nonfragment_hash * tests-pass: py27, py36 * notes: adjustment to _safe_chars suggested by @Gallaecio
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 95.3% 95.31% +<.01%
==========================================
Files 7 7
Lines 469 470 +1
Branches 93 93
==========================================
+ Hits 447 448 +1
Misses 15 15
Partials 7 7
|
Gallaecio
approved these changes
May 10, 2019
Gallaecio
changed the title
Member
|
Hey! I think canonicalize_url changes are good, but I'm not sure how it affects other functions - is it a right thing to do for safe_url_string, etc.? Could you please add tests for other affected functions as well? |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't decode
%23to#when it appears in a URLFixes #91