Merge paper.js 0.12.7 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node v11 is temporarily disabled from ci build until a bug is fixed in resemblejs package.
Add missing return values in Rectangle boolean operations. Closes paperjs#1399
Group selected color was applied differently to its bounds and position depending on whether it had children or not when selected color was set. This resulted in an unpredictable behaviour from a user point of view. To change that: - When `item.setSelectedColor()` is called, value is now always stored in `item._style._values`, independently from the fact that item has children or not. - An helper method `compareCanvas()` is added to the test suite to allow comparing selection rendering of a known working case to a failing one. Two provided callbacks are executed in a dedicated `<canvas>`/`Project` context and both results are compared with `resemble.js`.
Divide operation was described as subtract & subtract instead of subtract & intersect.
PathItem was misspelled PahtItem, breaking documentation links.
Several documentation "see also" links concerning beans were broken because they were referenced as `ClassName#getProperty()` instead of `ClassName#property`.
@see tag was pointing to an inherited method which is not compatible with current jsdoc parser implementation. Problem is resolved by making reference point to the parent class owning the method.
Empty parameter was resulting in `Path(pathData)` being documented as `Path(, pathData)` with an empty first parameter.
Empty raster (for example coming from path with empty bound rasterization, ...) drawing threw error. This change prevent raster drawing in that case. Closes paperjs#1320
Add param type in Raster#getPixel and Raster#setPixel
…ter-method Add param type in raster method
Line class was not displayed in online documentation but it was parsed and a file was created for it because it lacked a @Private JSDoc tag.
- typos in comments - wrong or missing types - missing default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's been a while since the last merge.