Explicit disabling of workspace resizing#653
Merged
tmickel merged 2 commits intoscratchfoundation:developfrom Oct 4, 2016
Merged
Explicit disabling of workspace resizing#653tmickel merged 2 commits intoscratchfoundation:developfrom
tmickel merged 2 commits intoscratchfoundation:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #639, as we discussed. Now resizing is explicitly disabled when clearing the workspace, and importing blocks from XML. But when those operations are finished, the workspace is resized in
workspace.setResizesEnabled(true).As a fun experiment, I also added calls to this when a block drag begins/ends. This means the workspace is no longer resized when insertion markers are created/destroyed, which I think we also discussed at some point. It seems to work well so far!