Skip to content

Black arrow on green tooltips #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 1, 2025
+4 −5
Merged

Black arrow on green tooltips #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
307ee65
fix: add background-color to element so the arrow is the same colour too
kbangelov Dec 1, 2025
97f416a
fix: add background-color to element so the arrow is the same colour too
kbangelov Dec 1, 2025
249d686
fix: implemented same logic with imported css color passed to jsx com…
kbangelov Dec 1, 2025
e692052
Merge branch 'bugfix/uepr-421-fix-black-arrow-on-green-tooltips' of g…
kbangelov Dec 1, 2025
d9a651d
fix: removed unnecessary lines and brought back wrongly deleted
kbangelov Dec 1, 2025
6f0ba0d
chore: deleted lines
kbangelov Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/scratch-gui/src/components/action-menu/action-menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ button::-moz-focus-inner {
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif !important;
}

.tooltip:after {
background-color: $extensions-primary;
}

.coming-soon-tooltip {
background-color: $data-primary !important;
}
Expand All @@ -158,6 +154,7 @@ button::-moz-focus-inner {
box-shadow: 0 0 .5rem hsla(0, 0%, 0%, .25) !important;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif !important;
z-index: $z-index-tooltip !important;
--tooltip-arrow-color: $extensions-primary;
}

$arrow-size: 0.5rem;
Expand Down Expand Up @@ -197,4 +194,4 @@ $arrow-rounding: 0.125rem;
margin-left: $arrow-inset !important;
top: $arrow-inset !important;
transform: rotate(-45deg) !important;
}
}
2 changes: 2 additions & 0 deletions packages/scratch-gui/src/components/action-menu/action-menu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ class ActionMenu extends React.Component {
effect="solid"
id={this.mainTooltipId}
place={tooltipPlace || 'left'}
arrowColor="var(--tooltip-arrow-color)"
/>
<div className={styles.moreButtonsOuter}>
<div className={styles.moreButtons}>
Expand Down Expand Up @@ -179,6 +180,7 @@ class ActionMenu extends React.Component {
effect="solid"
id={tooltipId}
place={tooltipPlace || 'left'}
arrowColor="var(--tooltip-arrow-color)"
/>
</div>
);
Expand Down
Loading