Skip to content

[UEPR-572] Track thumbnail updates#523

Merged
adzhindzhi merged 2 commits intodevelopfrom
bugfix/uepr-572-track-thumbnail-updates
Apr 14, 2026
Merged

[UEPR-572] Track thumbnail updates#523
adzhindzhi merged 2 commits intodevelopfrom
bugfix/uepr-572-track-thumbnail-updates

Conversation

@adzhindzhi
Copy link
Copy Markdown
Contributor

@adzhindzhi adzhindzhi commented Apr 14, 2026

Resolves

UEPR-572

Proposed Changes

Pass onSetManualThumbnail/onSetManualThumbnailButtonClick, callbacks to be executed when the Manually set thumbnail button is clicked (before confirming), and when the thumbnail is manually set

Reason for Changes

Fixes an issue where we used to track all thumbnail updates, including on project creation

@adzhindzhi adzhindzhi requested a review from a team as a code owner April 14, 2026 11:09
Comment thread packages/scratch-gui/src/components/stage-header/stage-header.jsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Test Results

  3 files   -     5   69 suites   - 1 009   11m 21s ⏱️ - 1m 29s
403 tests  - 2 302  395 ✅  - 2 302  8 💤 ± 0  0 ❌ ±0 
425 runs   - 5 826  417 ✅  - 5 795  8 💤  - 31  0 ❌ ±0 

Results for commit fb204d1. ± Comparison against base commit 38308ff.

This pull request removes 2302 tests.
buildLibraries Should NOT fill global assets from sprites if fillAssetsFromSprites is false ‑ buildLibraries Should NOT fill global assets from sprites if fillAssetsFromSprites is false
buildLibraries Should NOT inherit costume tags from sprites if costume already has tags ‑ buildLibraries Should NOT inherit costume tags from sprites if costume already has tags
buildLibraries Should NOT inherit sound tags from sprites ‑ buildLibraries Should NOT inherit sound tags from sprites
buildLibraries Should always extract dataFormat from file extension ‑ buildLibraries Should always extract dataFormat from file extension
buildLibraries Should deduplicate assets with the same name, ignoring casing ‑ buildLibraries Should deduplicate assets with the same name, ignoring casing
buildLibraries Should fill global costumes from sprites if fillAssetsFromSprites is true ‑ buildLibraries Should fill global costumes from sprites if fillAssetsFromSprites is true
buildLibraries Should fill sounds from global libraries even when fillAssetsFromSprites is false ‑ buildLibraries Should fill sounds from global libraries even when fillAssetsFromSprites is false
buildLibraries Should handle duplicate asset names in different sprites by including only one in the global library ‑ buildLibraries Should handle duplicate asset names in different sprites by including only one in the global library
buildLibraries Should handle invalid JSON files gracefully ‑ buildLibraries Should handle invalid JSON files gracefully
buildLibraries Should handle missing files gracefully ‑ buildLibraries Should handle missing files gracefully
…

♻️ This comment has been updated with latest results.

@adzhindzhi adzhindzhi merged commit 7e194bc into develop Apr 14, 2026
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants