Sprites displaying incorrectly in editor (dev)

[kosiecki17]

While viewing sprites in dev: previews in the library are correct, but when the sprite loads in the stage, it is missing pieces and has other pieces that are displaying incorrectly. Costumes appear normal. When you move a piece of the sprite in the paint editor, they update and display correctly on the stage. All of the additional costumes are displaying correctly.

So far I have only found 2 sprites with this specific issue: Andie and Bat.

In the case of the bat sprite, the ears are displaying incorrectly in both places, as well as in all of the additional costumes.

In the case of Andie, the missing pieces aren't all separate vectors in the SVG.

Mac OS 10.13.6 Chrome 71.0.3578.80

[fsih]

Paul wrote a script to compare svgs before and after treatment with SVGRenderer which is super helpful, thanks Paul! costumes-before-after-v2-svg-renderer.html.zip

Here are the broken results I found. I think I'm seeing 3 things

1. Missing pieces issue
2. Fills turning black issue
3. Strokes becoming thin

For 1 and 2, I suspect it's the recent change to SVGRenderer, scratchfoundation/scratch-svg-renderer#62. I'll investigate.

For 3, @kosiecki17 I think the tufts on the bat becoming thin might be an issue that's been around for awhile? I'm seeing it on beta.scratch.mit.edu. I wonder if it's a custom Illustrator thing that doesn't work when you view it elsewhere? We could convert the strokes to shapes if we want to keep how it looks.
Kind of oddly though, doesn't it look like the 3 thin strokes are more intentionally placed than the overlapping thick ones? (What if it's Illustrator that was displaying it wrong?)

[kosiecki17]

Those tufts on the bat's ears do not have strokes in the SVG files.
They look like strokes in the paint editor, but are shapes there as well.
I thought they were rounded strokes until I looked closer.

[fsih]

Oh no, the ones with missing pieces use masks allll over the place X|
I think we decided we weren't going to support masks, but we can't really do that if they're in our library

[kyleplo]

Oh, and the bat's left leg.

[fsih]

Status:
For issue 1, @kosiecki17 is working on removing masks from the bat costumes and andie-a
For issue 2, scratchfoundation/scratch-svg-renderer#68 is up
For issue 3, we figured out that the ear tufts are supposed to be thin

[kosiecki17]

I've updated all of the costumes for the bat. The ears were a separate issue. I did not find any clues as to why the left arm and leg would not be displaying.
I've also updated Andie's first costume.

I found no clipping masks in any of these files while viewing them in illustrator. I also opened them in a text reader and searched the SVG for the words "clipping" and "mask." If there are other ways for me to check this, let me know.