Build scratch-* dependencies with babel-loader #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschamp
suggested changes
May 10, 2018
webpack.config.js
Outdated
| test: /\.jsx?$/, | ||
| loader: 'babel-loader', | ||
| include: path.resolve(__dirname, 'src') | ||
| include: [path.resolve(__dirname, 'src'), /node_modules[\\\/]scratch-[^\\\/]+[\\\/]src/], |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
mzgoddard
force-pushed
the
dependents-no-boiler
branch
from
bc04354 to
7b98080
Compare
rschamp
previously approved these changes
May 10, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
I believe with the resolve.symlinks: false change I made these are all good to go! I will do that tomorrow.
Contributor
|
We ran into an issue with using this setup with npm > 4. When packages are linked (as they are frequently when working on 3.0), running |
Configure loaders so they operate on individual modules in scratch-* dependencies.
rschamp
force-pushed
the
dependents-no-boiler
branch
from
e71ca4a to
1848faa
Compare
rschamp
previously approved these changes
May 29, 2018
rschamp
force-pushed
the
dependents-no-boiler
branch
from
1848faa to
3470969
Compare
rschamp
approved these changes
May 29, 2018
adroitwhiz
added a commit
to adroitwhiz/scratch-gui
that referenced
this pull request
Jul 8, 2019
adroitwhiz
added a commit
to adroitwhiz/scratch-gui
that referenced
this pull request
Jul 11, 2019
This reverts commit 09d236e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Reason for Changes
Sibling of scratchfoundation/scratch-vm#1106