Remove manual refresh for scratch-blocks workspace#779
Merged
paulkaplan merged 1 commit intoOct 18, 2017
Conversation
fsih
approved these changes
Oct 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Previous issues (#413) required manually refreshing the scratch-blocks workspace. It is now dealt with from within scratch-blocks, so these manual calls need to be removed for performance-sake. This removes two unnecessary calls when switching between costume/sounds => blocks tab, and one unnecessary call when switching between sprites. Further optimization to this is being tracked scratchfoundation/scratch-blocks#1145
Test Coverage
Please show how you have added tests to cover your changes
Tested manually against the scenarios from issue #413.