Comment validation #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisandagain
previously approved these changes
Jun 15, 2018
Contributor
thisandagain
left a comment
thisandagain
left a comment
There was a problem hiding this comment.
Looks good! One minor change that we be nice to have prior to landing.
lib/sb3_definitions.json
Outdated
| "type": "object", | ||
| "properties": { | ||
| "blockId": {"$ref": "#/definitions/optionalString"}, | ||
| "text": {"type": "string"}, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
Author
|
@thisandagain, added an 8000 character limit. |
kchadha
force-pushed
the
comment-validation
branch
from
0668a90 to
328b5a3
Compare
thisandagain
approved these changes
Jun 16, 2018
Contributor
Author
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for sb3 projects with comments.
Added test fixtures for 2 sb3 projects with comments. One is a valid project, and the other is an invalid project (has a property of the wrong type for one of the comments).
This should issue a minor version bump because there is a new feature but no breaking changes.