Skip to content

Conversation

@kchadha
Copy link
Contributor

@kchadha kchadha commented Mar 15, 2019

remove gzip dependency and support for gzip files as that was an unused code path

BREAKING CHANGE: Gzipped files are no longer supported as input to the parser.

remove gzip dependency and support for gzip files as that was an unused code path

BREAKING CHANGE: Gzipped files are no longer supported as input to the parser.
Copy link
Contributor

@thisandagain thisandagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this feels like it should be considered a breaking change rather than a refactor.

@kchadha
Copy link
Contributor Author

kchadha commented Mar 18, 2019

I think it semantic-release should detect that it's a breaking change because of the comment in the commit message. At least that's how commitizen sets up the messages.

@kchadha kchadha dismissed thisandagain’s stale review March 18, 2019 20:53

Already fixed.

@kchadha kchadha merged commit cee1200 into scratchfoundation:master Mar 18, 2019
@kchadha kchadha deleted the remove-gzip-js branch March 18, 2019 20:53
@kchadha
Copy link
Contributor Author

kchadha commented Mar 18, 2019

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants