[IBE-561] Setup circleci#65
Conversation
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
Since this repo uses semantic-release it's going to need a couple extra steps. Other than that, though, this looks good. Thanks!
| before_script: | ||
| - npm prune | ||
| script: | ||
| - commitlint-travis |
There was a problem hiding this comment.
Since this repo uses semantic-release, I'd recommend keeping commitlint in the CI steps. There's no commitlint-travis on CircleCI, of course, but there is an Orb for it. You can find an example here:
https://github.com/LLK/scratch-gui/blob/develop/.circleci/config.yml#L4
https://github.com/LLK/scratch-gui/blob/develop/.circleci/config.yml#L216-L219
Once you add that, commitlint will start complaining about the commits in this PR. You'll need to rephrase them according to the Conventional Commits spec.
The easiest way is probably to run git rebase -i 0d9ea0b^ and then pick r for "reword" on all your commits.
meyerhot95
force-pushed
the
tsm/circleci
branch
from
9cc4e51 to
2f469cf
Compare
meyerhot95
force-pushed
the
tsm/circleci
branch
from
a862483 to
73379e4
Compare
| when: | ||
| not: | ||
| or: | ||
| - equal: [ master, <<pipeline.git.branch>> ] | ||
| - equal: [ develop, <<pipeline.git.branch>> ] | ||
| - matches: { pattern: "^hotfix.*", value: <<pipeline.git.branch>> } | ||
| - matches: { pattern: "^release.*", value: <<pipeline.git.branch>> } |
There was a problem hiding this comment.
I hadn't thought to filter this, but that's a good idea. I should add this to other repos!
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Resolves
https://scratchfoundation.atlassian.net/browse/IBE-561
Proposed Changes
Move from travis to circle while retaining maximal continuity with old config.
Reason for Changes
Deprecating travis
Test Coverage
Manually tested