Use src/index for browser entry point #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgoddard
force-pushed
the
dependents-no-boiler
branch
from
a954066 to
47473dc
Compare
cwillisf
approved these changes
May 9, 2018
| }, | ||
| externals: { | ||
| '!ify-loader!grapheme-breaker': 'grapheme-breaker', | ||
| '!ify-loader!linebreak': 'linebreak', |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Downstream webpack will need any dependencies src/ depends on so it can successfully build. Also if multiple packages being built into a larger script share a common dependency version range, they can share the dependency instead of duplicating it. This will save built file size, execution time, and memory.
rschamp
force-pushed
the
dependents-no-boiler
branch
from
47473dc to
9b869e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
srcas non-dev dependenciesReason for Changes
Sibling of scratchfoundation/scratch-vm#1106