Skip to content

fix: attempt to parse all string responses as JSON #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rschamp merged 1 commit into from
Oct 10, 2018
Merged

fix: attempt to parse all string responses as JSON #48

rschamp merged 1 commit into from
Oct 10, 2018

Conversation

@benjiwheeler
Copy link
Contributor

@benjiwheeler benjiwheeler commented Oct 10, 2018

resolves: #47

@benjiwheeler benjiwheeler added this to the October 2018 milestone Oct 10, 2018
@benjiwheeler
Copy link
Contributor Author

benjiwheeler commented Oct 10, 2018

Good to merge?

@benjiwheeler benjiwheeler requested a review from rschamp October 10, 2018 16:21
rschamp
rschamp approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@rschamp rschamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this looks pretty good to me! I wonder why?

@rschamp rschamp merged commit 63f2d90 into scratchfoundation:develop Oct 10, 2018
@rschamp rschamp deleted the parse-everything branch October 10, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rschamp rschamp rschamp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rschamp rschamp

Labels

pr - good to merge

Projects

None yet

Milestone

October 2018

Development

Successfully merging this pull request may close these issues.

WebHelper returns strange object after project json PUT; creating new project using POST does not return id

2 participants

@benjiwheeler @rschamp