Dynamically load music extension manifest #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rschamp
suggested changes
May 2, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
Thanks @mzgoddard, I think this looks good, just some comments would be helpful.
|
|
||
| if (!assetData[fullPath]) return; | ||
| return this._fetchSounds() | ||
| .catch(() => ({})) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| _fetchSounds () { | ||
| if (!this._assetData) { | ||
| this._assetData = new Promise((resolve, reject) => { | ||
| require.ensure([], () => { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
mzgoddard
force-pushed
the
dynamic-load-music
branch
from
4249172 to
da53956
Compare
mzgoddard
force-pushed
the
dynamic-load-music
branch
from
da53956 to
ff7b575
Compare
rschamp
approved these changes
May 7, 2018
This was referenced May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Dynamically load the 1.6MB of music extension sample files dynamically.
Reason for Changes
Split the music extension samples to be loaded separate from the main scripts to need less to be downloaded and for faster first execution of those scripts so Scratch starts earlier.
This change uses webpack's chunking to dynamically load the music extension files. An improvement would be to fetch the files as data through fetch/xhr base64 encoded json content or as a sound sprite.
Dynamically loaded separate from the main scripts, music samples could be preloaded with a script tag, in this format, or with an audio or link tag in the html body if it was encoded in a json file or sound sprite. This would load the file near the same time of the main scripts without blocking their execution.