Multi monitors #1742
Merged
Multi monitors #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport and during monitor id generation. Update monitors integration test to include sensing_current block monitors.
paulkaplan
approved these changes
Nov 8, 2018
Contributor
paulkaplan
left a comment
paulkaplan
left a comment
There was a problem hiding this comment.
LGTM... so strange though... thank you for documenting.
paulkaplan
reviewed
Nov 8, 2018
Contributor
Author
This was referenced Nov 11, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #1717
Resolves scratchfoundation/scratch-gui#1218
Proposed Changes
Allow multiple monitors for blocks with parameters.
In Scratch 3.0, we currently have three examples of reporter blocks that are monitor-able (have a checkbox in the flyout) and also have a parameter which determines what is being monitored. The changes in this PR make it so that monitors with the same reporter but different values for the parameter can be shown simultaneously (e.g. have a monitor for current year as well as current minute showing on the stage).
Also resolves a bug where
was not importing properly into 3.0.
Reason for Changes
The above was previously not working.
Test Coverage
1. Show monitors for all of the options for the
(current [v year])block.1.5 Observe that day of the week has the correct value where Sunday = 1.
2. Selectively hide some of these monitors.
3. Rinse and Repeat.
4. Repeat steps 1-3 for the
(costume [v number])and the(backdrop [v number])blocksImport 260563473.
cc/ @picklesrus