Add method for collecting all targets' assets #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves scratchfoundation#1601. Does not include the project JSON since that would require knowledge of a project ID, which the VM has not been responsible for so far. For now, it is the responsibility of the consumer to determine if these assets should be saved or not. Otherwise the VM would need to be responsible for saving, which has been out of its scope.
9 tasks
cwillisf
approved these changes
Nov 15, 2018
Contributor
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
This looks fine to me, though I commented on a potential simplification...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Resolves #1601
Proposed Changes
Describe what this Pull Request does
Adds a VM getter that returns all assets stored on all targets.
Reason for Changes
Explain why these changes should be made
Towards incremental saving, this gives a way for the GUI to save all the assets individually. For now, it is the responsibility of the consumer to determine if these assets should be saved or not. Otherwise the VM would need to be responsible for saving, which has been out of its scope. Does not include the project JSON since that would require knowledge of a project ID, which the VM has not been responsible for so far.
Test Coverage
Please show how you have added tests to cover your changes
Added unit tests for the function as well as the getter on the VM.