Update sensing_of fields if variable gets renamed #2425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @adroitwhiz and @fsih for some advice! (This is basically re-work of #2330)
Resolves
Resolves scratchfoundation/scratch-gui#4392
Proposed Changes
Adds a new function,
updateSensingOfReference, similiar to existingupdateAssetName. This checks for every block thatsensing_ofand changes the property.
Reason for Changes
Variable blocks will change their variable name by itself, but sensing_of does not. This will make sensing_of blocks referencing the variable return 0 when they are renamed.
Test Coverage
Added type test and 4 tests: