This repository was archived by the owner on Aug 12, 2022. It is now read-only.
add generic setAnalyticsPref functions for iOS and Android #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgarrity
suggested changes
Aug 14, 2020
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
There are a few changes. One of the main things is to make sure not to convert parameters to strings too early. One of the upcoming wkwebview changes is how parameters get passed, so while the two interfaces may look identical right now, they won't be soon
android/ScratchJr/app/src/main/java/org/scratchjr/android/JavaScriptDirectInterface.java
Outdated
Show resolved
Hide resolved
android/ScratchJr/app/src/main/java/org/scratchjr/android/ScratchJrActivity.java
Outdated
Show resolved
Hide resolved
src/tablet/Android.js
Outdated
| AndroidInterface.setAnalyticsPlacePref(preferredPlace); | ||
| } | ||
|
|
||
| static setAnalyticsPref (jsonStr) { |
Contributor
There was a problem hiding this comment.
The parameter here should just be json, the interface should take care of stringify or whatever conversion is needed to pass to the native code.
src/tablet/iOS.js
Outdated
| window.tablet.setAnalyticsPlacePref(preferredPlace); | ||
| } | ||
|
|
||
| static setAnalyticsPref (jsonStr) { |
Contributor
There was a problem hiding this comment.
Parameter should just be json, and this method should take care of the stringify.
| JSONArray jsonArray = jsonObject.names(); | ||
| String key = jsonArray.getString(0); | ||
| String value = jsonObject.getString(key); | ||
| _FirebaseAnalytics.setUserProperty(key, value); |
Contributor
There was a problem hiding this comment.
If it's parsed in the interface this is much simpler.
chrisgarrity
suggested changes
Aug 14, 2020
android/ScratchJr/app/src/main/java/org/scratchjr/android/JavaScriptDirectInterface.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Adds setAnalyticsPref functions for iOS and Android
Adds functions in js to call those native functions, with a single interface