Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -629,4 +629,24 @@ public void setAnalyticsPlacePref(String place) {
_activity.setAnalyticsPlacePref(place);
}
}

/**
* Record a user property
* @param prefObjStr single key-value JSON string, like "{\"school\": \"Central High\"}"
*/
@JavascriptInterface
public void setAnalyticsPref(String prefObjStr) {
if (prefObjStr != null) {
try {
JSONObject jsonObject = new JSONObject(prefObjStr);
JSONArray jsonArray = jsonObject.names();
String key = jsonArray.getString(0);
String value = jsonObject.getString(key);
_activity.setAnalyticsPref(key, value);
} catch (JSONException e) {
Log.e(LOG_TAG, "JSON error: " + e.getMessage(), e);
return;
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,15 @@ public void setAnalyticsPlacePref(String place) {
_FirebaseAnalytics.setUserProperty("place_preference", place);
}

/**
* Record a user property
* @param key like "school"
* @param value like "Central High"
*/
public void setAnalyticsPref(String key, String value) {
_FirebaseAnalytics.setUserProperty(key, value);
}

public void translateAndScaleRectToContainerCoords(RectF rect, float devicePixelRatio) {
float wx = _webView.getX();
float wy = _webView.getY();
Expand Down
1 change: 1 addition & 0 deletions ios/ScratchJr/src/ScratchJr.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@
- (NSString *) deviceName;
- (NSString *) analyticsEvent:(NSString *)category :(NSString *)action :(NSString *)label;
- (void) setAnalyticsPlacePref:(NSString *)place;
- (void) setAnalyticsPref:(NSString *)prefObjStr;
@end

@interface ViewController : UIViewController <JSExports,UIWebViewDelegate,MFMailComposeViewControllerDelegate>
Expand Down
10 changes: 10 additions & 0 deletions ios/ScratchJr/src/ViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,16 @@ -(void) setAnalyticsPlacePref:(NSString*)place {
[FIRAnalytics setUserPropertyString:place forName:@"place_preference"];
}

// @param prefObjStr like "{\"place_preference\": \"School\"}"
-(void) setAnalyticsPref:(NSString*)prefObjStr {
NSData* data = [prefObjStr dataUsingEncoding:NSUTF8StringEncoding];
NSDictionary* dict = [NSJSONSerialization JSONObjectWithData:data options:0 error: nil];
NSString *key = [[dict allKeys] firstObject];
NSString *value = [dict objectForKey: key];
[FIRAnalytics setUserPropertyString:value forName:key];
}


// iPad name (used for information in the name/sharing dialog to help people using Airdrop)
- (NSString*) deviceName {
return [[UIDevice currentDevice] name];
Expand Down
4 changes: 4 additions & 0 deletions src/tablet/Android.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ export default class Android {
AndroidInterface.setAnalyticsPlacePref(preferredPlace);
}

static setAnalyticsPref (obj) {
AndroidInterface.setAnalyticsPref(JSON.stringify(obj));
}

// // Web Wiew delegate call backs
//
// static pageError (desc) {
Expand Down
4 changes: 4 additions & 0 deletions src/tablet/OS.js
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,10 @@ export default class OS {
tabletInterface.setAnalyticsPlacePref(preferredPlace);
}

static setAnalyticsPref (key, value) {
tabletInterface.setAnalyticsPref({[key]: value});
}

// Web Wiew delegate call backs

static pageError (desc) {
Expand Down
4 changes: 4 additions & 0 deletions src/tablet/iOS.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,10 @@ export default class iOS {
window.tablet.setAnalyticsPlacePref(preferredPlace);
}

static setAnalyticsPref (obj) {
window.tablet.setAnalyticsPref(JSON.stringify(obj));
}

// // Web Wiew delegate call backs
//
// static pageError (desc) {
Expand Down