This repository was archived by the owner on Aug 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 326
add support for custom options questions at app start; refactor index.js #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgarrity
suggested changes
Aug 20, 2020
Contributor
chrisgarrity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic to ask the questions looks good, but it looks like it doesn't use the settings each time the app starts. I also have a suggestion for making it localizable even if we don't use localization for the first edition that uses custom options.
Contributor
Author
|
OK, take a look now! |
Contributor
Author
|
@chrisgarrity Note that you'll need to change your settings.json file, to replace with |
benjiwheeler
commented
Aug 20, 2020
chrisgarrity
approved these changes
Aug 21, 2020
Contributor
chrisgarrity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I confirmed with both a custom set of user preferences and the old 'place_preference'. Both came through on the analytics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Testing notes
I tested this in the iOS Simulator and Android Studio Emulator.
I also tested this on an iPad mini running iOS 9.3.5 (which should verify that there is no ES6-specific js)