Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.

Conversation

@benjiwheeler
Copy link
Contributor

@benjiwheeler benjiwheeler commented Aug 14, 2020

Resolves

Proposed Changes

  • add support for custom options questions at app start
  • rename AppUsage.js to InitialOptions.js, expand functionality beyond place preference to arbitrary options
  • refactor index.js

Testing notes

I tested this in the iOS Simulator and Android Studio Emulator.

I also tested this on an iPad mini running iOS 9.3.5 (which should verify that there is no ES6-specific js)

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic to ask the questions looks good, but it looks like it doesn't use the settings each time the app starts. I also have a suggestion for making it localizable even if we don't use localization for the first edition that uses custom options.

@benjiwheeler
Copy link
Contributor Author

OK, take a look now!

@benjiwheeler
Copy link
Contributor Author

@chrisgarrity Note that you'll need to change your settings.json file, to replace

            "key": "place",
            "firstTime": true,
            "type": "place"

with

            "key": "place_preference",
            "firstTime": true,
            "type": "place_preference"

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed with both a custom set of user preferences and the old 'place_preference'. Both came through on the analytics.

@benjiwheeler benjiwheeler merged commit 0cb154e into develop Aug 24, 2020
@benjiwheeler benjiwheeler deleted the custom-option-questions branch August 24, 2020 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for arbitrary options questions on app startup

3 participants